xiangfu0 commented on a change in pull request #7880:
URL: https://github.com/apache/pinot/pull/7880#discussion_r765627144
##########
File path:
pinot-tools/src/main/java/org/apache/pinot/tools/service/PinotServiceManager.java
##########
@@ -210,18 +210,24 @@ public boolean stopPinotInstance(ServiceStartable
instance) {
}
}
- public void start() {
- LOGGER.info("Registering service status handler");
- ServiceStatus.setServiceStatusCallback(_instanceId, new
PinotServiceManagerStatusCallback(this));
-
+ public void start(boolean bootstrapMode) {
if (_port < 0) {
LOGGER.info("Skip Starting Pinot Service Manager admin application");
} else {
+ LOGGER.info("Registering service status handler");
+ ServiceStatus.setServiceStatusCallback(_instanceId, new
PinotServiceManagerStatusCallback(this));
+
LOGGER.info("Starting Pinot Service Manager admin application on port:
{}", _port);
_pinotServiceManagerAdminApplication = new
PinotServiceManagerAdminApiApplication(this);
_pinotServiceManagerAdminApplication.start(_port);
}
- _isStarted = true;
+ if (!bootstrapMode) {
+ _isStarted = true;
Review comment:
we do have this _isStarted per instance and used in the nested
ServiceStatus.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
