walterddr commented on a change in pull request #7804:
URL: https://github.com/apache/pinot/pull/7804#discussion_r764521707
##########
File path:
pinot-spi/src/main/java/org/apache/pinot/spi/data/DateTimeFormatPatternSpec.java
##########
@@ -52,7 +66,28 @@ public DateTimeFormatPatternSpec(String timeFormat, String
sdfPatternWithTz) {
String timezoneString = m.group(TIMEZONE_GROUP).trim();
_dateTimeZone =
DateTimeZone.forTimeZone(TimeZone.getTimeZone(timezoneString));
}
+ validateSdfPattern(_sdfPattern, requireLexicographicOrdering);
_dateTimeFormatter =
DateTimeFormat.forPattern(_sdfPattern).withZone(_dateTimeZone).withLocale(DEFAULT_LOCALE);
+
+ }
+ }
+
+ private static void validateSdfPattern(String sdfPattern, boolean
requireLexicographicOrdering) {
Review comment:
done. but I still put the logic in spi, alongside with the other
DateTimeFieldSpec validate methods. (we need those to run first before we can
determine the schema is actually simple date format).
for now my goal is to make this bug fix. later I can follow up with the
validate code refactor out of SPI into common.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
