yupeng9 commented on a change in pull request #7860:
URL: https://github.com/apache/pinot/pull/7860#discussion_r762339390
##########
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/PartitionUpsertMetadataManager.java
##########
@@ -193,12 +175,6 @@ public GenericRow updateRecord(IndexSegment segment,
RecordInfo recordInfo, Gene
if
(recordInfo._comparisonValue.compareTo(currentRecordLocation.getComparisonValue())
>= 0) {
IndexSegment currentSegment = currentRecordLocation.getSegment();
int currentDocId = currentRecordLocation.getDocId();
- if (_partialUpsertHandler != null) {
Review comment:
I think we shall keep the partial upsert merge logic, as the
groovy-based partial upsert logic can trigger some default logic even for newly
ingested record
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
