richardstartin commented on a change in pull request #7820:
URL: https://github.com/apache/pinot/pull/7820#discussion_r760433750
##########
File path:
pinot-core/src/test/java/org/apache/pinot/queries/JsonPathQueriesTest.java
##########
@@ -55,17 +60,37 @@
private static final String LONG_COLUMN = "longColumn";
private static final String STRING_COLUMN = "stringColumn";
private static final String JSON_COLUMN = "jsonColumn";
+ private static final String RAW_JSON_COLUMN = "rawJsonColumn";
+ private static final String RAW_BYTES_COLUMN = "rawBytesColumn";
+ private static final String DICTIONARY_BYTES_COLUMN =
"dictionaryBytesColumn";
+ private static final String RAW_STRING_COLUMN = "rawStringColumn";
+ private static final String DICTIONARY_STRING_COLUMN =
"dictionaryStringColumn";
private static final String JSON_COLUMN_WITHOUT_INDEX =
"jsonColumnWithoutIndex";
private static final Schema SCHEMA = new
Schema.SchemaBuilder().setSchemaName(RAW_TABLE_NAME)
.addSingleValueDimension(INT_COLUMN, FieldSpec.DataType.INT)
.addSingleValueDimension(LONG_COLUMN, FieldSpec.DataType.LONG)
.addSingleValueDimension(STRING_COLUMN, FieldSpec.DataType.STRING)
.addSingleValueDimension(JSON_COLUMN, FieldSpec.DataType.JSON)
+ .addSingleValueDimension(RAW_JSON_COLUMN, FieldSpec.DataType.JSON)
+ .addSingleValueDimension(RAW_BYTES_COLUMN, FieldSpec.DataType.BYTES)
Review comment:
@kishoreg I don't think that's what @amrishlal was saying, this test
focuses on jsonpath literals like `select * from table where foo.bar = 0` and
these only work on JSON columns, so adding these other columns here so
`jsonextractscalar` can be tested using the thorough set up this tests provides
doesn't feel appropriate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
