Jackie-Jiang commented on a change in pull request #7822:
URL: https://github.com/apache/pinot/pull/7822#discussion_r755606608
##########
File path:
pinot-clients/pinot-jdbc-client/src/main/java/org/apache/pinot/client/PinotConnection.java
##########
@@ -40,11 +41,20 @@
private PinotControllerTransport _controllerTransport;
PinotConnection(String controllerURL, PinotClientTransport transport, String
tenant) {
- this(controllerURL, transport, tenant, null);
+ this(controllerURL, transport, tenant, null, new Properties());
+ }
+
+ PinotConnection(String controllerURL, PinotClientTransport transport, String
tenant, Properties extraProps) {
Review comment:
Consider following the same order of the arguments as `Connection` (put
`properties` as the first argument)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
