mayankshriv commented on a change in pull request #7820:
URL: https://github.com/apache/pinot/pull/7820#discussion_r755550432
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/common/DataBlockCache.java
##########
@@ -120,6 +121,17 @@ public int getNumDocs() {
return intValues;
}
+ /**
+ * Get the int values for a single-valued column.
+ *
+ * @param column Column name
+ * @param evaluator JSON path evaluator
+ * @param buffer values to fill
+ */
+ public void fillValues(String column, JsonPathEvaluator evaluator, int[]
buffer) {
Review comment:
Does it make sense to have a more generic evaluator abstraction (with
JsonPathEvaluator as one of the impls) here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
