Jackie-Jiang commented on a change in pull request #7816:
URL: https://github.com/apache/pinot/pull/7816#discussion_r754764826
##########
File path:
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/ResultSetGroup.java
##########
@@ -53,8 +54,18 @@
}
}
}
-
_executionStats = brokerResponse.getExecutionStats();
+ _exceptions = getPinotClientExceptions(brokerResponse.getExceptions());
+ }
+
+ private static List<PinotClientException> getPinotClientExceptions(JsonNode
exceptionsJson) {
Review comment:
Annotate `exceptionsJson` as nullable
##########
File path:
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/Connection.java
##########
@@ -34,14 +35,23 @@
private static final Logger LOGGER =
LoggerFactory.getLogger(Connection.class);
private final PinotClientTransport _transport;
private final BrokerSelector _brokerSelector;
+ private final Config _config;
Connection(List<String> brokerList, PinotClientTransport transport) {
- LOGGER.info("Creating connection to broker list {}", brokerList);
- _brokerSelector = new SimpleBrokerSelector(brokerList);
- _transport = transport;
+ this(new Config(), new SimpleBrokerSelector(brokerList), transport);
+ }
+
+ Connection(Config config, List<String> brokerList, PinotClientTransport
transport) {
Review comment:
Suggest directly passing in the `Properties`. Don't see much value
wrapping it into a custom object. `Properties` is more general and easy to be
extended in the future
##########
File path:
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/Connection.java
##########
@@ -222,4 +232,28 @@ public ResultSetGroup get(long timeout, TimeUnit unit)
return new ResultSetGroup(response);
}
}
+
+
+ public static class Config {
+ public static final String FAIL_ON_EXCEPTIONS = "fail_on_exceptions";
Review comment:
We don't usually use `_` in the config key, so suggest using camel case
for consistency
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
