weixiangsun commented on a change in pull request #7781: URL: https://github.com/apache/pinot/pull/7781#discussion_r753604745
########## File path: pinot-core/src/main/java/org/apache/pinot/core/query/reduce/GapFillGroupByDataTableReducer.java ########## @@ -0,0 +1,483 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.core.query.reduce; + +import java.io.Serializable; +import java.util.ArrayList; +import java.util.Arrays; +import java.util.Collection; +import java.util.HashMap; +import java.util.HashSet; +import java.util.Iterator; +import java.util.List; +import java.util.Map; +import java.util.Set; +import java.util.concurrent.TimeUnit; +import java.util.concurrent.TimeoutException; +import java.util.stream.Collectors; +import org.apache.pinot.common.exception.QueryException; +import org.apache.pinot.common.metrics.BrokerGauge; +import org.apache.pinot.common.metrics.BrokerMeter; +import org.apache.pinot.common.metrics.BrokerMetrics; +import org.apache.pinot.common.request.context.ExpressionContext; +import org.apache.pinot.common.request.context.FilterContext; +import org.apache.pinot.common.response.broker.BrokerResponseNative; +import org.apache.pinot.common.response.broker.QueryProcessingException; +import org.apache.pinot.common.response.broker.ResultTable; +import org.apache.pinot.common.utils.DataSchema; +import org.apache.pinot.common.utils.DataSchema.ColumnDataType; +import org.apache.pinot.common.utils.DataTable; +import org.apache.pinot.core.data.table.ConcurrentIndexedTable; +import org.apache.pinot.core.data.table.IndexedTable; +import org.apache.pinot.core.data.table.Key; +import org.apache.pinot.core.data.table.Record; +import org.apache.pinot.core.data.table.SimpleIndexedTable; +import org.apache.pinot.core.data.table.UnboundedConcurrentIndexedTable; +import org.apache.pinot.core.operator.combine.GroupByOrderByCombineOperator; +import org.apache.pinot.core.query.aggregation.function.AggregationFunction; +import org.apache.pinot.core.query.request.context.QueryContext; +import org.apache.pinot.core.transport.ServerRoutingInstance; +import org.apache.pinot.core.util.GroupByUtils; +import org.apache.pinot.core.util.trace.TraceCallable; +import org.apache.pinot.spi.data.DateTimeFormatSpec; +import org.apache.pinot.spi.data.DateTimeGranularitySpec; + + +/** + * Helper class to reduce data tables and set group by results into the BrokerResponseNative + */ +@SuppressWarnings({"rawtypes", "unchecked"}) +public class GapFillGroupByDataTableReducer implements DataTableReducer { + private static final int MIN_DATA_TABLES_FOR_CONCURRENT_REDUCE = 2; // TBD, find a better value. + + private final QueryContext _queryContext; + private final AggregationFunction[] _aggregationFunctions; + private final int _numAggregationFunctions; + private final List<ExpressionContext> _groupByExpressions; + private final int _numGroupByExpressions; + private final int _numColumns; + private final boolean _sqlQuery; + private final DateTimeGranularitySpec _dateTimeGranularity; + private final DateTimeFormatSpec _dateTimeFormatter; + private final long _startMs; + private final long _endMs; + private final Set<Key> _primaryKeys; + private final Map<Key, Object[]> _previous; + private final int _numOfKeyColumns; + + GapFillGroupByDataTableReducer(QueryContext queryContext) { + _queryContext = queryContext; + _aggregationFunctions = queryContext.getAggregationFunctions(); + assert _aggregationFunctions != null; + _numAggregationFunctions = _aggregationFunctions.length; + _groupByExpressions = queryContext.getGroupByExpressions(); + assert _groupByExpressions != null; + _numGroupByExpressions = _groupByExpressions.size(); + _numColumns = _numAggregationFunctions + _numGroupByExpressions; + _sqlQuery = queryContext.getBrokerRequest().getPinotQuery() != null; + + ExpressionContext firstExpressionContext = _queryContext.getSelectExpressions().get(0); + List<ExpressionContext> args = firstExpressionContext.getFunction().getArguments(); + _dateTimeFormatter = new DateTimeFormatSpec(args.get(1).getLiteral()); + _dateTimeGranularity = new DateTimeGranularitySpec(args.get(4).getLiteral()); + String start = args.get(2).getLiteral(); + String end = args.get(3).getLiteral(); + _startMs = truncate(_dateTimeFormatter.fromFormatToMillis(start)); + _endMs = truncate(_dateTimeFormatter.fromFormatToMillis(end)); + _primaryKeys = new HashSet<>(); + _previous = new HashMap<>(); + _numOfKeyColumns = _queryContext.getGroupByExpressions().size() - 1; + } + + private long truncate(long epoch) { + int sz = _dateTimeGranularity.getSize(); + return epoch / sz * sz; + } + + /** + * Reduces and sets group by results into ResultTable, if responseFormat = sql + * By default, sets group by results into GroupByResults + */ + @Override + public void reduceAndSetResults(String tableName, DataSchema dataSchema, + Map<ServerRoutingInstance, DataTable> dataTableMap, BrokerResponseNative brokerResponseNative, + DataTableReducerContext reducerContext, BrokerMetrics brokerMetrics) { + assert dataSchema != null; + Collection<DataTable> dataTables = dataTableMap.values(); + + // 1. groupByMode = sql, responseFormat = sql + // This is the primary SQL compliant group by + + try { + setSQLGroupByInResultTable(brokerResponseNative, dataSchema, dataTables, reducerContext, tableName, + brokerMetrics); + } catch (TimeoutException e) { + brokerResponseNative.getProcessingExceptions() + .add(new QueryProcessingException(QueryException.BROKER_TIMEOUT_ERROR_CODE, e.getMessage())); + } + int resultSize = brokerResponseNative.getResultTable().getRows().size(); + + if (brokerMetrics != null && resultSize > 0) { + brokerMetrics.addMeteredTableValue(tableName, BrokerMeter.GROUP_BY_SIZE, resultSize); + } + } + + private Key constructKey(Object[] row) { + return new Key(Arrays.copyOfRange(row, 1, _numOfKeyColumns + 1)); + } + + /** + * Extract group by order by results and set into {@link ResultTable} + * @param brokerResponseNative broker response + * @param dataSchema data schema + * @param dataTables Collection of data tables + * @param reducerContext DataTableReducer context + * @param rawTableName table name + * @param brokerMetrics broker metrics (meters) + * @throws TimeoutException If unable complete within timeout. + */ + private void setSQLGroupByInResultTable(BrokerResponseNative brokerResponseNative, DataSchema dataSchema, + Collection<DataTable> dataTables, DataTableReducerContext reducerContext, String rawTableName, + BrokerMetrics brokerMetrics) + throws TimeoutException { + IndexedTable indexedTable = getIndexedTable(dataSchema, dataTables, reducerContext); + if (brokerMetrics != null) { + brokerMetrics.addMeteredTableValue(rawTableName, BrokerMeter.NUM_RESIZES, indexedTable.getNumResizes()); + brokerMetrics.addValueToTableGauge(rawTableName, BrokerGauge.RESIZE_TIME_MS, indexedTable.getResizeTimeMs()); + } + Iterator<Record> sortedIterator = indexedTable.iterator(); + DataSchema prePostAggregationDataSchema = getPrePostAggregationDataSchema(dataSchema); + ColumnDataType[] columnDataTypes = prePostAggregationDataSchema.getColumnDataTypes(); + int numColumns = columnDataTypes.length; + int limit = _queryContext.getLimit(); + List<Object[]> rows = new ArrayList<>(limit); + + if (_sqlQuery) { + // SQL query with SQL group-by mode and response format + + PostAggregationHandler postAggregationHandler = + new PostAggregationHandler(_queryContext, prePostAggregationDataSchema); + FilterContext havingFilter = _queryContext.getHavingFilter(); + if (havingFilter != null) { + HavingFilterHandler havingFilterHandler = new HavingFilterHandler(havingFilter, postAggregationHandler); + while (rows.size() < limit && sortedIterator.hasNext()) { + Object[] row = sortedIterator.next().getValues(); + extractFinalAggregationResults(row); + for (int i = 0; i < numColumns; i++) { + row[i] = columnDataTypes[i].convert(row[i]); + } + if (havingFilterHandler.isMatch(row)) { + rows.add(row); + } + } + } else { + for (int i = 0; i < limit && sortedIterator.hasNext(); i++) { + Object[] row = sortedIterator.next().getValues(); + extractFinalAggregationResults(row); + for (int j = 0; j < numColumns; j++) { + row[j] = columnDataTypes[j].convert(row[j]); + } + rows.add(row); + } + } + DataSchema resultDataSchema = postAggregationHandler.getResultDataSchema(); + ColumnDataType[] resultColumnDataTypes = resultDataSchema.getColumnDataTypes(); + List<Object[]> resultRows = new ArrayList<>(rows.size()); + for (Object[] row : rows) { + Object[] resultRow = postAggregationHandler.getResult(row); + for (int i = 0; i < resultColumnDataTypes.length; i++) { + resultRow[i] = resultColumnDataTypes[i].format(resultRow[i]); + } + resultRows.add(resultRow); + _primaryKeys.add(constructKey(resultRow)); + } + List<Object[]> gapfillResultRows = gapFill(resultRows, resultColumnDataTypes); + brokerResponseNative.setResultTable(new ResultTable(resultDataSchema, gapfillResultRows)); + } else { + // PQL query with SQL group-by mode and response format + // NOTE: For PQL query, keep the order of columns as is (group-by expressions followed by aggregations), no need + // to perform post-aggregation or filtering. + + for (int i = 0; i < limit && sortedIterator.hasNext(); i++) { + Object[] row = sortedIterator.next().getValues(); + extractFinalAggregationResults(row); + for (int j = 0; j < numColumns; j++) { + row[j] = columnDataTypes[j].convertAndFormat(row[j]); + } + rows.add(row); + } + brokerResponseNative.setResultTable(new ResultTable(prePostAggregationDataSchema, rows)); + } + } + + List<Object[]> gapFill(List<Object[]> resultRows, ColumnDataType[] resultColumnDataTypes) { + int limit = _queryContext.getLimit(); + int numResultColumns = resultColumnDataTypes.length; + List<Object[]> gapfillResultRows = new ArrayList<>(limit); + long step = _dateTimeGranularity.granularityToMillis(); + int index = 0; + for (long time = _startMs; time + 2 * step <= _endMs; time += step) { + Set<Key> keys = new HashSet<>(_primaryKeys); + while (index < resultRows.size()) { + long timeCol = _dateTimeFormatter.fromFormatToMillis(String.valueOf(resultRows.get(index)[0])); Review comment: Fixed. Also Test case is added to verify it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
