mqliang commented on pull request #7724: URL: https://github.com/apache/pinot/pull/7724#issuecomment-974493791
@kishoreg > have we measured the impact of measuring these numbers? We benchmarked, JVM have the stats for each thread, this measuring just retrieve the number from JVM, so the overhead is negligible. In addition, the measuring is disabled by default: https://github.com/apache/pinot/blob/6611ff82f46ea837e6bd8edefd46ccc16d4e2002/pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java#L404 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
