richardstartin commented on a change in pull request #7777: URL: https://github.com/apache/pinot/pull/7777#discussion_r751782162
########## File path: pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/groupby/DictionaryBasedGroupKeyGenerator.java ########## @@ -587,6 +617,20 @@ public LongMapBasedHolder(Long2IntOpenHashMap groupIdMap) { @Override public void processSingleValue(int numDocs, int[] outGroupIds) { + if (_numGroupByExpressions == 1) { Review comment: Ok I will roll this back, the change was motivated by the int cases I found in profiles and I added this for consistency. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org