mneedham opened a new pull request #7768:
URL: https://github.com/apache/pinot/pull/7768
At the moment if you run the QuickStart with a missing type you'll get this
error:
```
docker run -p 9000:9000
apachepinot/pinot:0.9.0-SNAPSHOT-362f3e1ac-20211114-jdk11 QuickStart
```
```
java.lang.NullPointerException
at
org.apache.pinot.tools.admin.command.QuickStartCommand.execute(QuickStartCommand.java:99)
at org.apache.pinot.tools.Command.call(Command.java:33)
at org.apache.pinot.tools.Command.call(Command.java:29)
at picocli.CommandLine.executeUserObject(CommandLine.java:1953)
at picocli.CommandLine.access$1300(CommandLine.java:145)
at
picocli.CommandLine$RunLast.executeUserObjectOfLastSubcommandWithSameParent(CommandLine.java:2352)
at picocli.CommandLine$RunLast.handle(CommandLine.java:2346)
at picocli.CommandLine$RunLast.handle(CommandLine.java:2311)
at
picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.java:2179)
at picocli.CommandLine.execute(CommandLine.java:2078)
at
org.apache.pinot.tools.admin.PinotAdministrator.execute(PinotAdministrator.java:161)
at
org.apache.pinot.tools.admin.PinotAdministrator.main(PinotAdministrator.java:192)
```
And if you pass in an invalid type:
```
docker run -p 9000:9000
apachepinot/pinot:0.9.0-SNAPSHOT-362f3e1ac-20211114-jdk11 QuickStart -type foo
```
```
java.lang.UnsupportedOperationException: Unsupported QuickStart type: foo
at
org.apache.pinot.tools.admin.command.QuickStartCommand.execute(QuickStartCommand.java:156)
at org.apache.pinot.tools.Command.call(Command.java:33)
at org.apache.pinot.tools.Command.call(Command.java:29)
at picocli.CommandLine.executeUserObject(CommandLine.java:1953)
at picocli.CommandLine.access$1300(CommandLine.java:145)
at
picocli.CommandLine$RunLast.executeUserObjectOfLastSubcommandWithSameParent(CommandLine.java:2352)
at picocli.CommandLine$RunLast.handle(CommandLine.java:2346)
at picocli.CommandLine$RunLast.handle(CommandLine.java:2311)
at
picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.java:2179)
at picocli.CommandLine.execute(CommandLine.java:2078)
at
org.apache.pinot.tools.admin.PinotAdministrator.execute(PinotAdministrator.java:161)
at
org.apache.pinot.tools.admin.PinotAdministrator.main(PinotAdministrator.java:192)
```
Neither of these messages tells the user the valid types that they can pass
in.
So that's what this PR attempts to solve.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
