snleee commented on a change in pull request #7744:
URL: https://github.com/apache/pinot/pull/7744#discussion_r747774811
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java
##########
@@ -2858,10 +2883,11 @@ public void endReplaceSegments(String
tableNameWithType, String segmentLineageEn
.format("Invalid segment lineage entry id (tableName='%s',
segmentLineageEntryId='%s')", tableNameWithType,
segmentLineageEntryId));
- // NO-OPS if the entry is already completed
- if (lineageEntry.getState() == LineageEntryState.COMPLETED) {
- LOGGER.warn("Lineage entry state is already COMPLETED. Nothing to
update. (tableNameWithType={}, "
- + "segmentLineageEntryId={})", tableNameWithType,
segmentLineageEntryId);
+ // NO-OPS if the entry is already 'COMPLETED' or 'REVERTED'
+ if (lineageEntry.getState() != LineageEntryState.IN_PROGRESS) {
+ LOGGER.warn("Lineage entry state is not IN_PROGRESS. Nothing to
update. (tableNameWithType={}, "
Review comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
