amrishlal commented on a change in pull request #7568:
URL: https://github.com/apache/pinot/pull/7568#discussion_r746144491
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/ProjectionOperator.java
##########
@@ -68,6 +72,36 @@ public String getOperatorName() {
return OPERATOR_NAME;
}
+ @Override
+ public String getExplainPlanName() {
+ return EXPLAIN_NAME;
+ }
+
+ @Override
+ public List<Operator> getChildOperators() {
+ return Collections.singletonList(_docIdSetOperator);
+ }
+
+ @Override
+ public String toExplainString() {
+ StringBuilder stringBuilder = new
StringBuilder(getExplainPlanName()).append('(');
+ if (_dataSourceMap.keySet().isEmpty()) {
+ // count aggregation function has empty input expressions
+ stringBuilder.append("ALL");
Review comment:
The comment appears to be incorrect. I don't see this block of code
being invoked when `count(*)` is used. There is a test case for `count(*)`
query.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
