Jackie-Jiang commented on a change in pull request #7712:
URL: https://github.com/apache/pinot/pull/7712#discussion_r744017945
##########
File path:
pinot-tools/src/main/java/org/apache/pinot/tools/perf/QueryRunner.java
##########
@@ -255,6 +257,13 @@ public boolean execute()
return true;
}
+ public static QuerySummary singleThreadedQueryRunner(PerfBenchmarkDriverConf
conf, List<String> queries,
+ int numTimesToRunQueries, int reportIntervalMs, int
numIntervalsToReportAndClearStatistics, long timeout)
+ throws Exception {
+ return singleThreadedQueryRunner(conf, queries, numTimesToRunQueries,
reportIntervalMs,
+ numIntervalsToReportAndClearStatistics, timeout, new HashMap<>());
Review comment:
(minor) `Collections.emptyMap()` if we don't add new field on the fly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
