Jackie-Jiang commented on pull request #7708: URL: https://github.com/apache/pinot/pull/7708#issuecomment-962229421
> Don't merge this, I don't think it has any test coverage beyond quick start (which is a bit concerning) All the tests using `StringDictionary` should cover this part. But yes we don't have a dedicate test for `FixedByteValueReaderWriter` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
