jasperjiaguo commented on a change in pull request #7653:
URL: https://github.com/apache/pinot/pull/7653#discussion_r740648677
##########
File path:
pinot-core/src/main/java/org/apache/pinot/server/access/AllowAllAccessFactory.java
##########
@@ -16,13 +16,19 @@
* specific language governing permissions and limitations
* under the License.
*/
-package org.apache.pinot.server.api.access;
+package org.apache.pinot.server.access;
Review comment:
@apucher In `BaseServerStarter` we have
```String accessControlFactoryClass =
_serverConf.getProperty(Server.ACCESS_CONTROL_FACTORY_CLASS,
Server.DEFAULT_ACCESS_CONTROL_FACTORY_CLASS);```
where I have changed `DEFAULT_ACCESS_CONTROL_FACTORY_CLASS` to
`org.apache.pinot.server.access.AllowAllAccessFactory`, and left
`ACCESS_CONTROL_FACTORY_CLASS` unchanged
(`pinot.server.admin.access.control.factory.class`).
So if the current installation is using default (not configuring
`pinot.server.admin.access.control.factory.class`) or configuring it to
customized class there should be no problem.
IIUC, the only case that will cause problem is someone explicitly configured
`pinot.server.admin.access.control.factory.class` to
`org.apache.pinot.server.api.access.AllowAllAccessFactory`. Do you know any use
case configured in this way?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
