xiangfu0 commented on a change in pull request #7664:
URL: https://github.com/apache/pinot/pull/7664#discussion_r739723180



##########
File path: 
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
##########
@@ -270,6 +274,11 @@ private BrokerResponseNative handleSQLRequest(long 
requestId, String query, Json
     if (_enableQueryLimitOverride) {
       handleQueryLimitOverride(pinotQuery, _queryResponseLimit);
     }
+    if (_enableSegmentPartitionedDistinctCountOverride
+        || 
QueryOptionsUtils.enableSegmentPartitionedDistinctCountOverride(pinotQuery.getQueryOptions()))
 {
+      handleSegmentPartitionedDistinctCountOverride(pinotQuery,

Review comment:
       Actually I feel broker side is the right place.
   E.g. if a hybrid table has configured this only for offline but not realtime 
 table, then we cannot perform the override.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to