jtao15 commented on a change in pull request #7617:
URL: https://github.com/apache/pinot/pull/7617#discussion_r734910389
##########
File path:
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/mergerollup/MergeRollupTaskGenerator.java
##########
@@ -254,7 +251,9 @@ public String getTaskType() {
long bucketEndMs = bucketStartMs + bucketMs;
// Create delay metrics even if there's no task scheduled, this helps
the case that the controller is restarted
// but the metrics are not available until the controller schedules a
valid task
- createOrUpdateDelayMetrics(offlineTableName, mergeLevel, watermarkMs,
bufferMs, bucketMs);
+ long maxEndTimeMs = preSelectedSegments.get(preSelectedSegments.size()
- 1).getEndTimeMs();
Review comment:
Good catch! Updated to loop through the segments and compute the max
value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
