weixiangsun commented on a change in pull request #7584: URL: https://github.com/apache/pinot/pull/7584#discussion_r733933204
########## File path: pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/AggregationFunctionFactory.java ########## @@ -156,6 +158,45 @@ public static AggregationFunction getAggregationFunction(FunctionContext functio return new AvgAggregationFunction(firstArgument); case MODE: return new ModeAggregationFunction(arguments); + case LASTWITHTIME: + if (arguments.size() > 1) { + ExpressionContext timeCol = arguments.get(1); + String dataType = arguments.get(2).getIdentifier(); + DataSchema.ColumnDataType columnDataType = DataSchema.ColumnDataType.valueOf(dataType.toUpperCase()); + switch (columnDataType) { + case BOOLEAN: + case INT: + return new LastIntValueWithTimeAggregationFunction( + firstArgument, + timeCol, + ObjectSerDeUtils.INT_VAL_TIME_PAIR_SER_DE, Review comment: Done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org