richardstartin commented on a change in pull request #7568:
URL: https://github.com/apache/pinot/pull/7568#discussion_r727438086
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/AcquireReleaseColumnsSegmentOperator.java
##########
@@ -77,6 +81,16 @@ public String getOperatorName() {
return OPERATOR_NAME;
}
+ @Override
+ public String getExplainPlanName() {
+ return EXPLAIN_NAME;
+ }
+
+ @Override
+ public List<Operator> getChildOperators() {
+ return Arrays.asList(_childOperator);
Review comment:
Can you replace all of these one element `Arrays.asList(arg)` with
`Collections.singletonList(arg)` - just because it creates IDE warnings
otherwise, and it's nice to keep SNR high with IDE warnings.
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/AcquireReleaseColumnsSegmentOperator.java
##########
@@ -77,6 +81,16 @@ public String getOperatorName() {
return OPERATOR_NAME;
}
+ @Override
+ public String getExplainPlanName() {
+ return EXPLAIN_NAME;
+ }
+
+ @Override
+ public List<Operator> getChildOperators() {
+ return Arrays.asList(_childOperator);
Review comment:
Of course, it wasn't a really a _review_ comment, just something that
stood out at me glancing at the diff.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
