fritzb commented on issue #7489: URL: https://github.com/apache/pinot/issues/7489#issuecomment-940612959
@jadireddi Simple Date Format has caching routine inside Joda library DateTimeFormatter, which will avoid new objects getting allocated on a similar pattern call. Adding <code>tz()</code> parsing to derive the timezone will cause the scalar function to not utilize the caching performance. You could redo the caching implementation in DateTimePatternHandler, but thats an extra complexity. The chosen implementation was the second option, with timezone as 3rd argument. Thanks for your comment, I refactored the code just now and moved all the formatting and parsing logic inside DateTimePatternHandler. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
