jtao15 commented on a change in pull request #7481:
URL: https://github.com/apache/pinot/pull/7481#discussion_r725391969
##########
File path:
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/mergerollup/MergeRollupTaskGenerator.java
##########
@@ -371,17 +471,26 @@ private boolean isMergedSegment(SegmentZKMetadata
segmentZKMetadata, String merg
}
/**
- * Check if the merge window end time is valid
+ * Get the merge window end time
*/
- private boolean isValidMergeWindowEndTime(long windowEndMs, long bufferMs,
String lowerMergeLevel,
- MergeRollupTaskMetadata mergeRollupTaskMetadata) {
- // Check that execution window endTimeMs <= now - bufferTime
- if (windowEndMs > System.currentTimeMillis() - bufferMs) {
- return false;
+ private long getMergeWindowEndTime(long windowStartMs, long bucketMs, long
numParallelBuckets, long bufferMs,
Review comment:
Good point. I've removed the fixed window end time and use the bucket
end time instead. The bucket start/end time is bumped up dynamically, so this
case will be covered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
