Jackie-Jiang commented on a change in pull request #7511:
URL: https://github.com/apache/pinot/pull/7511#discussion_r723756504
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/optimizer/statement/JsonStatementOptimizer.java
##########
@@ -384,13 +383,34 @@ private static void optimizeJsonPredicate(Expression
expression, @Nullable Table
}
/**
- * @return A string array containing all the parts of an identifier. An
identifier may have one or more parts that
- * are joined together using <DOT>. For example the identifier
"testTable.jsonColumn.name.first" consists up of
- * "testTable" (name of table), "jsonColumn" (name of column), "name" (json
path), and "first" (json path). The last
- * two parts when joined together (name.first) represent a JSON path
expression.
+ * @return A two element String array where the first element is the column
name and second element is the JSON
+ * path expression. If column name is not suffixed by JSON path expression,
then array will contain only a single
+ * element representing the column name. For example:
+ * 1) Identifier "jsonColumn.name.first" -> {"jsonColumn", "name.first"}
Review comment:
```suggestion
* 1) Identifier "jsonColumn.name.first" -> {"jsonColumn", ".name.first"}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
