walterddr opened a new pull request #7523:
URL: https://github.com/apache/pinot/pull/7523


   Based on 
   
https://docs.pinot.apache.org/operators/operating-pinot/pinot-managed-offline-flows
   
   Currently the task configs are not parsed until task generation, which 
should be validated sooner. Adding a validation for realtimeToOffline task
   
   However a more general solution should be:
   1. add validateConfig method to PinotTaskGenerator
   2. make validateTaskConfigs reflectively call validateConfig provided by the 
concrete impl of PinotTaskGenerator  
   
   This way we don't really need to duplicate config checkers between 
PinotTaskGenerator impl and within TableConfigUtils. (such as the task name 
copy and all other config parsing logic)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to