Jackie-Jiang commented on a change in pull request #7493:
URL: https://github.com/apache/pinot/pull/7493#discussion_r718768587
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/combine/BaseCombineOperator.java
##########
@@ -153,7 +154,18 @@ public void runJob() {
*/
protected void processSegments(int threadIndex) {
for (int operatorIndex = threadIndex; operatorIndex < _numOperators;
operatorIndex += _numThreads) {
- IntermediateResultsBlock resultsBlock = (IntermediateResultsBlock)
_operators.get(operatorIndex).nextBlock();
+ Operator operator = _operators.get(operatorIndex);
+ IntermediateResultsBlock resultsBlock;
+ try {
+ if (operator instanceof AcquireReleaseColumnsSegmentOperator) {
+ ((AcquireReleaseColumnsSegmentOperator) operator).acquire();
+ }
Review comment:
I think this should be outside of the try block, so that we don't
release the operator if acquire fails. Same for other places
##########
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/readers/NullValueVectorReaderImpl.java
##########
@@ -25,18 +25,20 @@
public class NullValueVectorReaderImpl implements NullValueVectorReader {
- private final ImmutableRoaringBitmap _nullBitmap;
+ private final PinotDataBuffer _dataBuffer;
public NullValueVectorReaderImpl(PinotDataBuffer dataBuffer) {
- _nullBitmap = new ImmutableRoaringBitmap(dataBuffer.toDirectByteBuffer(0,
(int) dataBuffer.size()));
+ _dataBuffer = dataBuffer;
}
public boolean isNull(int docId) {
- return _nullBitmap.contains(docId);
+ ImmutableRoaringBitmap nullBitmap =
+ new ImmutableRoaringBitmap(_dataBuffer.toDirectByteBuffer(0, (int)
_dataBuffer.size()));
+ return nullBitmap.contains(docId);
Review comment:
(nit)
```suggestion
@Override
public boolean isNull(int docId) {
return getNullBitmap().contains(docId);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
