jackjlli commented on a change in pull request #7488:
URL: https://github.com/apache/pinot/pull/7488#discussion_r717268854
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/ControllerConf.java
##########
@@ -66,10 +66,14 @@
public static final String CONTROLLER_MODE = "controller.mode";
public static final String LEAD_CONTROLLER_RESOURCE_REBALANCE_STRATEGY =
"controller.resource.rebalance.strategy";
- // Comma separated list of list of packages that contain TableConfigTuners
to be added to the registry
+ // Comma separated list of packages that contain TableConfigTuners to be
added to the registry
public static final String TABLE_CONFIG_TUNER_PACKAGES =
"controller.table.config.tuner.packages";
public static final String DEFAULT_TABLE_CONFIG_TUNER_PACKAGES =
"org.apache.pinot";
+ // Comma separated list of packages that contains javax service resources.
+ private static final String CONTROLLER_RESOURCE_PACKAGES =
"org.apache.pinot.controller.api.resources";
Review comment:
Should the package name contain a `.package` suffix here?
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/ControllerConf.java
##########
@@ -66,10 +66,14 @@
public static final String CONTROLLER_MODE = "controller.mode";
public static final String LEAD_CONTROLLER_RESOURCE_REBALANCE_STRATEGY =
"controller.resource.rebalance.strategy";
- // Comma separated list of list of packages that contain TableConfigTuners
to be added to the registry
+ // Comma separated list of packages that contain TableConfigTuners to be
added to the registry
public static final String TABLE_CONFIG_TUNER_PACKAGES =
"controller.table.config.tuner.packages";
public static final String DEFAULT_TABLE_CONFIG_TUNER_PACKAGES =
"org.apache.pinot";
+ // Comma separated list of packages that contains javax service resources.
+ private static final String CONTROLLER_RESOURCE_PACKAGES =
"org.apache.pinot.controller.api.resources";
Review comment:
Looks good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
