richardstartin commented on a change in pull request #7487:
URL: https://github.com/apache/pinot/pull/7487#discussion_r716736742
##########
File path: pinot-spi/src/main/java/org/apache/pinot/spi/utils/ByteArray.java
##########
@@ -31,6 +34,21 @@
* </ul>
*/
public class ByteArray implements Comparable<ByteArray>, Serializable {
+
+ private static final MethodHandle COMPARE_UNSIGNED;
+
+ static {
+ MethodHandle compareUnsigned = null;
+ try {
+ compareUnsigned = MethodHandles.publicLookup().findStatic(Arrays.class,
"compareUnsigned",
+ MethodType.methodType(int.class,
+ byte[].class, int.class, int.class,
+ byte[].class, int.class, int.class));
+ } catch (NoSuchMethodException | IllegalAccessException ignore) {
Review comment:
Only on JDK8 AFAIK, but let's log it anyway
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
