klsince commented on a change in pull request #7435: URL: https://github.com/apache/pinot/pull/7435#discussion_r710406660
########## File path: pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/reader/RangeIndexReader.java ########## @@ -0,0 +1,100 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.segment.spi.index.reader; + +import java.io.Closeable; +import javax.annotation.Nullable; + +/** + * Interface for indexed range queries + * @param <T> + */ +public interface RangeIndexReader<T> extends Closeable { + /** + * Returns doc ids with a value between min and max, both inclusive. + * @param min the inclusive lower bound. + * @param max the inclusive upper bound. + * @return the matching doc ids. + */ + @Nullable + T getMatchingDocIds(int min, int max); + + /** + * Returns doc ids with a value between min and max, both inclusive. + * @param min the inclusive lower bound. + * @param max the inclusive upper bound. + * @return the matching doc ids. + */ + @Nullable + T getMatchingDocIds(long min, long max); + + /** + * Returns doc ids with a value between min and max, both inclusive. + * @param min the inclusive lower bound. + * @param max the inclusive upper bound. + * @return the matching doc ids. + */ + @Nullable + T getMatchingDocIds(float min, float max); + + /** + * Returns doc ids with a value between min and max, both inclusive. + * @param min the inclusive lower bound. + * @param max the inclusive upper bound. + * @return the matching doc ids. + */ + @Nullable + T getMatchingDocIds(double min, double max); + + /** + * Returns doc ids with a value between min and max, both inclusive. + * @param min the inclusive lower bound. + * @param max the inclusive upper bound. + * @return the matching doc ids. + */ + @Nullable Review comment: looks like the comments are identical for getMatchingDocIds() and getPartiallyMatchingDocIds(). I assume their behavior would be different. If so, perhaps highlight it in the comments? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
