walterddr commented on a change in pull request #7085:
URL: https://github.com/apache/pinot/pull/7085#discussion_r707567039
##########
File path:
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/creator/name/NormalizedDateSegmentNameGenerator.java
##########
@@ -53,6 +53,8 @@ public NormalizedDateSegmentNameGenerator(String tableName,
@Nullable String seg
boolean excludeSequenceId, @Nullable String pushType, @Nullable String
pushFrequency,
@Nullable DateTimeFormatSpec dateTimeFormatSpec) {
_segmentNamePrefix = segmentNamePrefix != null ? segmentNamePrefix.trim()
: tableName;
+ Preconditions.checkArgument(
+ _segmentNamePrefix == null || isValidSegmentName(_segmentNamePrefix));
Review comment:
good catch. forgot to change after merging the 2 rules.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
