liuchang0520 commented on a change in pull request #6778: URL: https://github.com/apache/pinot/pull/6778#discussion_r706765272
########## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/FileUploadDownloadClient.java ########## @@ -727,6 +727,23 @@ public SimpleHttpResponse uploadSegment(URI uri, String segmentName, InputStream return uploadSegment(uri, segmentName, inputStream, null, parameters, DEFAULT_SOCKET_TIMEOUT_MS); } + /** + * Controller periodic task uses this endpoint to ask servers to upload committed llc segment to segment store if missing. + * @param uri The uri to ask servers to upload segment to segment store + * @return the uploaded segment download url from segment store + * @throws URISyntaxException + * @throws IOException + * @throws HttpErrorStatusException + */ + public String uploadToSegmentStore(String uri) Review comment: I also thought about this. But I don't want to make this endpoint as a generic post, because it doesn't actually post with any payload. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org