atris commented on pull request #7405: URL: https://github.com/apache/pinot/pull/7405#issuecomment-917119089
It is already encapsulated within a package in Pinot-segment and has interfaces for interaction at each layer - please refer to the code On Fri, 10 Sep 2021, 23:35 Amrish Lal, ***@***.***> wrote: > I would suggest creating a new pinot-fst module for the new FST > implementation. > > Not sure about this.. we don't create modules at root level for other > indexing. Need to think carefully before creating modules at the root.. at > some point, ideally, we should create plugin mechanisms for indexes and > then create a module for each index.. we are not there yet > > It doesn't have to be a top-level module, but basically, I was looking for > some way to sufficiently encapsulate this FST implementation using > interfaces (in a separate jar if possible) and then use it within Pinot (?). > > For e.g., in this PR, ImmutableFST uses the off heap bytes store in > pinot-segment-local, thus creating a cyclic dependency. > Sounds like we need interfaces? > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/pinot/pull/7405#issuecomment-917104588>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AANE5Y2H7WNUCTP3VX5OJIDUBJCE3ANCNFSM5DTCLYZQ> > . > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
