[GitHub] [pinot] richardstartin opened a new issue #7410: User provided JsonPaths should be trimmed as early as possible

[GitBox]

richardstartin opened a new issue #7410:
URL: https://github.com/apache/pinot/issues/7410


   I noticed defensive calls to `String.trim` actually trimming the JSON path 
in a profile from a user, where these paths come from ingestion transformation 
configuration. 
   
   <img width="1457" alt="Screenshot 2021-09-08 at 11 15 08" 
src="https://user-images.githubusercontent.com/16439049/132492500-4265624d-80c3-42b6-a7eb-767722663491.png";>
   
   This means that:
   * the JSON path is trimmed at least once per ingested row, creating 
unnecessary allocation pressure
   * the lookups for cached compiled `JsonPath`s always uses a new `String` 
object, which means the JSON path's hash code is calculated at least once per 
ingested row.
   
   Cleaning JSON paths before initialising the record transformation would 
remedy this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org