richardstartin commented on pull request #7402: URL: https://github.com/apache/pinot/pull/7402#issuecomment-914659218
> Are we concluding that plain if statements has the best performance? One fact is that we don't really know the frequency of the input data type, so plain if statements might cause performance degradation We don't know, but the [JIT compiler does](http://cr.openjdk.java.net/~vlivanov/talks/2015_JIT_Overview.pdf) - it profiles branches, can remove (untaken branch pruning) and reorder them (branch frequency prediction) and so on. Do you have a schema in mind where this code is slower than the `HashMap` and could you demonstrate it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
