ckharide opened a new issue #7404:
URL: https://github.com/apache/pinot/issues/7404


   Hello -  I just started looking at the code and please ignore if this issue 
is addressed . 
   
   It seems the startServiceManager() method in StartServiceManagerCommand is 
not used also am curious why it returns the instanceID when the 
pinotServiceManager thread wouldn't have started .  Do you think  it would be 
good to return the instance ID only once the pinotServiceManager started 
successfully by using the state of the isStarted() method.  
   
   Let me know what do you think and i would be intersted to work on it if you 
permit .
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to