Jackie-Jiang commented on a change in pull request #7385:
URL: https://github.com/apache/pinot/pull/7385#discussion_r700466601
##########
File path:
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/OfflineClusterIntegrationTest.java
##########
@@ -355,9 +354,10 @@ public void testInvertedIndexTriggering()
}
}, 600_000L, "Failed to cleanup obsolete index");
// The table size after removing the index might not get back the original
one,
- // i.e. tableSizeWithDefaultIndex. Because entries in index_map file are
reordered,
- // and the file might get a different size. tableSizeAfterRemovingIndex
should be
- // close to tableSizeWithDefaultIndex, but their relationship is not
deterministic.
+ // i.e. tableSizeWithDefaultIndex. Because indices in column.psf file are
reordered,
Review comment:
When the index is removed, then the index order becomes deterministic,
and we can assert on the size across the tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
