[GitHub] [pinot] chenboat commented on a change in pull request #7374: Check schema backward-compatibility when updating schema through addSchema with override

[GitBox]

chenboat commented on a change in pull request #7374:
URL: https://github.com/apache/pinot/pull/7374#discussion_r697773259



##########
File path: 
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java
##########
@@ -1043,23 +1043,25 @@ public PinotResourceManagerResponse 
deleteBrokerTenantFor(String tenantName) {
   /**
    * Schema APIs
    */
-  public void addSchema(Schema schema, boolean override) {
+  public void addSchema(Schema schema, boolean override)

Review comment:
       can you add a test case for this change?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org