Jackie-Jiang commented on a change in pull request #7368:
URL: https://github.com/apache/pinot/pull/7368#discussion_r696959585
##########
File path:
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/MergeRollupMinionClusterIntegrationTest.java
##########
@@ -259,7 +260,7 @@ public void testSingleLevelConcat()
// {merged_100days_T4_1_16400_16404_1, myTable1_16405_16435_2}
// -> {merged_100days_T5_0_myTable1_16400_16435_0}
- String sqlQuery = "SELECT count(*) FROM mytable1"; // 115545 rows for the
test table
+ String sqlQuery = "SELECT count(*) FROM myTable1"; // 115545 rows for the
test table
Review comment:
Curious on how does is work before
##########
File path:
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/mergerollup/MergeRollupTaskGenerator.java
##########
@@ -277,6 +279,10 @@ public String getTaskType() {
}
Long prevWatermarkMs =
mergeRollupTaskMetadata.getWatermarkMap().put(mergeLevel, windowStartMs);
+ if (prevWatermarkMs != null) {
Review comment:
You want to emit metrics based on the new updated watermark instead of
the previous watermark
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
