klsince commented on a change in pull request #7286: URL: https://github.com/apache/pinot/pull/7286#discussion_r696833731
########## File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/invertedindex/JsonIndexHandler.java ########## @@ -104,8 +112,9 @@ private void createJsonIndexForColumn(ColumnMetadata columnMetadata) // Create new json index for the column. LOGGER.info("Creating new json index for segment: {}, column: {}", _segmentName, columnName); - Preconditions.checkState(columnMetadata.isSingleValue() && columnMetadata.getDataType() == DataType.STRING, - "Json index can only be applied to single-value STRING columns"); + Preconditions.checkState(columnMetadata.isSingleValue() && (columnMetadata.getDataType() == DataType.STRING Review comment: thinking to keep this one here as UT case is easier to add to cover this fix in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org