jackjlli commented on a change in pull request #7299:
URL: https://github.com/apache/pinot/pull/7299#discussion_r694356645
##########
File path:
pinot-plugins/pinot-batch-ingestion/v0_deprecated/pinot-hadoop/src/main/java/org/apache/pinot/hadoop/job/mappers/SegmentCreationMapper.java
##########
@@ -140,13 +140,16 @@ public void setup(Context context)
setFlagForSchemaMismatch();
// Set up segment name generator
- String segmentNameGeneratorType =
_jobConf.get(JobConfigConstants.SEGMENT_NAME_GENERATOR_TYPE,
JobConfigConstants.DEFAULT_SEGMENT_NAME_GENERATOR);
+ String segmentNameGeneratorType =
Review comment:
Basically the reformatting is just for adding data preprocessing support
on spark framework. And all the renaming changes are under the same parent
module. And I've already address with the latest master, so no big reformatting
changes here. So I think it should be fine to just keep it in one PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
