Jackie-Jiang commented on a change in pull request #7335:
URL: https://github.com/apache/pinot/pull/7335#discussion_r694192724
##########
File path: pinot-tools/src/main/java/org/apache/pinot/tools/SpeedTest.java
##########
@@ -32,40 +32,43 @@
*
*/
public class SpeedTest {
- static int SIZE = 10000000;
- static String FILE_NAME = "/tmp/big_data.dat";
- static double readPercentage = 0.9;
- static int[] heapStorage;
- static ByteBuffer directMemory;
- static MappedByteBuffer mmappedByteBuffer;
- static int[] readIndices;
+ private SpeedTest() {
Review comment:
This doesn't seem a util class. Change the static methods to non-static?
##########
File path: pinot-tools/src/main/java/org/apache/pinot/tools/SpeedTest.java
##########
@@ -32,40 +32,43 @@
*
*/
public class SpeedTest {
- static int SIZE = 10000000;
- static String FILE_NAME = "/tmp/big_data.dat";
- static double readPercentage = 0.9;
- static int[] heapStorage;
- static ByteBuffer directMemory;
- static MappedByteBuffer mmappedByteBuffer;
- static int[] readIndices;
+ private SpeedTest() {
+ }
+
+ static final int SIZE = 10000000;
Review comment:
Add `private`?
##########
File path: pinot-tools/src/main/resources/conf/sample_perf_benchmark.yaml
##########
@@ -17,7 +17,7 @@
# under the License.
#
-!!org.apache.pinot.tools.perf.PerfBenchmarkDriverConf
+ !!org.apache.pinot.tools.perf.PerfBenchmarkDriverConf
Review comment:
Is this correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
