xiangfu0 commented on a change in pull request #7325:
URL: https://github.com/apache/pinot/pull/7325#discussion_r691764097
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/DistinctCountBitmapMVAggregationFunction.java
##########
@@ -86,6 +86,7 @@ public void aggregate(int length, AggregationResultHolder
aggregationResultHolde
valueBitmap.add(Float.hashCode(value));
}
}
+ break;
Review comment:
bug found.
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/DistinctCountMVAggregationFunction.java
##########
@@ -93,6 +93,7 @@ public void aggregate(int length, AggregationResultHolder
aggregationResultHolde
floatSet.add(value);
}
}
+ break;
Review comment:
bug found.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
