Jackie-Jiang commented on a change in pull request #7226: URL: https://github.com/apache/pinot/pull/7226#discussion_r691673175
########## File path: pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/PercentileRawTDigestAggregationFunction.java ########## @@ -0,0 +1,142 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.core.query.aggregation.function; + +import com.tdunning.math.stats.TDigest; +import java.util.Map; +import org.apache.pinot.common.request.context.ExpressionContext; +import org.apache.pinot.common.utils.DataSchema.ColumnDataType; +import org.apache.pinot.core.common.BlockValSet; +import org.apache.pinot.core.query.aggregation.AggregationResultHolder; +import org.apache.pinot.core.query.aggregation.groupby.GroupByResultHolder; +import org.apache.pinot.segment.local.utils.CustomSerDeUtils; +import org.apache.pinot.segment.spi.AggregationFunctionType; +import org.apache.pinot.spi.utils.BytesUtils; + + +/** + * The {@code PercentileRawTDigestAggregationFunction} returns the serialized {@code TDigest} data structure of the + * {@code PercentileEstAggregationFunction}. + */ +public class PercentileRawTDigestAggregationFunction extends BaseSingleInputAggregationFunction<TDigest, String> { + private final PercentileTDigestAggregationFunction _percentileRawTDigestAggregationFunction; Review comment: Rename the variable ```suggestion private final PercentileTDigestAggregationFunction _percentileTDigestAggregationFunction; ``` ########## File path: pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/PercentileRawEstAggregationFunction.java ########## @@ -0,0 +1,141 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.core.query.aggregation.function; + +import java.util.Map; +import org.apache.pinot.common.request.context.ExpressionContext; +import org.apache.pinot.common.utils.DataSchema.ColumnDataType; +import org.apache.pinot.core.common.BlockValSet; +import org.apache.pinot.core.query.aggregation.AggregationResultHolder; +import org.apache.pinot.core.query.aggregation.groupby.GroupByResultHolder; +import org.apache.pinot.segment.local.customobject.QuantileDigest; +import org.apache.pinot.segment.local.utils.CustomSerDeUtils; +import org.apache.pinot.segment.spi.AggregationFunctionType; +import org.apache.pinot.spi.utils.BytesUtils; + + +/** + * The {@code PercentileRawEstAggregationFunction} returns the serialized {@code QuantileDigest} data structure of the + * {@code PercentileEstAggregationFunction}. + */ +public class PercentileRawEstAggregationFunction extends BaseSingleInputAggregationFunction<QuantileDigest, String> { + private final PercentileEstAggregationFunction _percentileRawEstAggregationFunction; Review comment: Same for this class ########## File path: pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/PercentileRawTDigestAggregationFunction.java ########## @@ -0,0 +1,142 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.core.query.aggregation.function; + +import com.tdunning.math.stats.TDigest; +import java.util.Map; +import org.apache.pinot.common.request.context.ExpressionContext; +import org.apache.pinot.common.utils.DataSchema.ColumnDataType; +import org.apache.pinot.core.common.BlockValSet; +import org.apache.pinot.core.query.aggregation.AggregationResultHolder; +import org.apache.pinot.core.query.aggregation.groupby.GroupByResultHolder; +import org.apache.pinot.segment.local.utils.CustomSerDeUtils; +import org.apache.pinot.segment.spi.AggregationFunctionType; +import org.apache.pinot.spi.utils.BytesUtils; + + +/** + * The {@code PercentileRawTDigestAggregationFunction} returns the serialized {@code TDigest} data structure of the + * {@code PercentileEstAggregationFunction}. + */ +public class PercentileRawTDigestAggregationFunction extends BaseSingleInputAggregationFunction<TDigest, String> { + private final PercentileTDigestAggregationFunction _percentileRawTDigestAggregationFunction; + + public PercentileRawTDigestAggregationFunction(ExpressionContext expressionContext, int percentile) { + this(expressionContext, new PercentileTDigestAggregationFunction(expressionContext, percentile)); + } + + public PercentileRawTDigestAggregationFunction(ExpressionContext expressionContext, double percentile) { + this(expressionContext, new PercentileTDigestAggregationFunction(expressionContext, percentile)); + } + + protected PercentileRawTDigestAggregationFunction(ExpressionContext expression, + PercentileTDigestAggregationFunction percentileRawTDigestAggregationFunction) { Review comment: Rename the parameter ```suggestion PercentileTDigestAggregationFunction percentileTDigestAggregationFunction) { ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
