klsince commented on a change in pull request #7301: URL: https://github.com/apache/pinot/pull/7301#discussion_r689933054
########## File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/store/IndexEntry.java ########## @@ -27,7 +28,7 @@ class IndexEntry { private static Logger LOGGER = LoggerFactory.getLogger(IndexEntry.class); - IndexKey key; + final IndexKey key; Review comment: turns out those are not private vars and get referred directly in SingleFileIndexDirectory. But they are in same package, so will leave them this way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org