[pinot] 01/01: Add TimeUnit to metrics in MinionQueryPhase

[jlli]

This is an automated email from the ASF dual-hosted git repository.

jlli pushed a commit to branch update-minion-metrics
in repository https://gitbox.apache.org/repos/asf/pinot.git

commit f7c67cf6b447881f342e1d5dfadc08628ae20eea
Author: Jack Li(Analytics Engineering) <j...@jlli-mn1.linkedin.biz>
AuthorDate: Mon Aug 16 09:30:14 2021 -0700

    Add TimeUnit to metrics in MinionQueryPhase
---
 .../org/apache/pinot/minion/taskfactory/TaskFactoryRegistry.java  | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git 
a/pinot-minion/src/main/java/org/apache/pinot/minion/taskfactory/TaskFactoryRegistry.java
 
b/pinot-minion/src/main/java/org/apache/pinot/minion/taskfactory/TaskFactoryRegistry.java
index 1913858..107610e 100644
--- 
a/pinot-minion/src/main/java/org/apache/pinot/minion/taskfactory/TaskFactoryRegistry.java
+++ 
b/pinot-minion/src/main/java/org/apache/pinot/minion/taskfactory/TaskFactoryRegistry.java
@@ -20,6 +20,7 @@ package org.apache.pinot.minion.taskfactory;
 
 import java.util.HashMap;
 import java.util.Map;
+import java.util.concurrent.TimeUnit;
 import org.apache.commons.lang3.StringUtils;
 import org.apache.helix.HelixManager;
 import org.apache.helix.task.JobContext;
@@ -79,14 +80,17 @@ public class TaskFactoryRegistry {
               // jobContext.getStartTime() return the time in milliseconds of 
job being put into helix queue.
               long jobInQueueTimeMs = jobContext.getStartTime();
               long jobDequeueTimeMs = System.currentTimeMillis();
-              _minionMetrics.addPhaseTiming(taskType, 
MinionQueryPhase.TASK_QUEUEING, jobDequeueTimeMs - jobInQueueTimeMs);
+              _minionMetrics
+                  .addPhaseTiming(taskType, MinionQueryPhase.TASK_QUEUEING, 
jobDequeueTimeMs - jobInQueueTimeMs,
+                      TimeUnit.MILLISECONDS);
               try {
                 
_minionMetrics.addValueToGlobalGauge(MinionGauge.NUMBER_OF_TASKS, 1L);
                 return runInternal();
               } finally {
                 
_minionMetrics.addValueToGlobalGauge(MinionGauge.NUMBER_OF_TASKS, -1L);
                 long executionTimeMs = System.currentTimeMillis() - 
jobDequeueTimeMs;
-                _minionMetrics.addPhaseTiming(taskType, 
MinionQueryPhase.TASK_EXECUTION, executionTimeMs);
+                _minionMetrics
+                    .addPhaseTiming(taskType, MinionQueryPhase.TASK_EXECUTION, 
executionTimeMs, TimeUnit.MILLISECONDS);
                 LOGGER.info("Task: {} completed in: {}ms", 
_taskConfig.getId(), executionTimeMs);
               }
             }

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org