mcvsubbu commented on a change in pull request #7306:
URL: https://github.com/apache/pinot/pull/7306#discussion_r689651939
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentUploadDownloadRestletResource.java
##########
@@ -235,7 +237,10 @@ private SuccessResponse uploadSegment(@Nullable String
tableName, TableType tabl
SegmentMetadata segmentMetadata = getSegmentMetadata(tempDecryptedFile,
tempSegmentDir, metadataProviderClass);
// Fetch segment name
- String segmentName = segmentMetadata.getName();
+ if (!StringUtils.isEmpty(segmentName)) {
Review comment:
Does segment load work fine? Used to be that the name in the segment
metadata is the source of truth for segment name. Has that changed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
