klsince opened a new pull request #7301: URL: https://github.com/apache/pinot/pull/7301
## Description This one is core implementation for https://github.com/apache/pinot/pull/7286. This PR does index cleanup for V3 segment format (V1 already has this feature). The general idea to clean up indices for V3 consists of two steps: mark and sweep. Calling removeIndex() marks the indices to be removed; sweep happens in close() method of SingleFileIndexDirectory. The index creation handlers are supposed to call removeIndex() by comparing local indices and those set in table config (adding these changes in next PR). No failure handling during sweep. It's expected to be called during segment reloading, which actually has failure handling (in short, by creating a backup folder before doing reloading, and restore with the backup folder upon any failure). ## Upgrade Notes Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion) * [ ] Yes (Please label as **<code>backward-incompat</code>**, and complete the section below on Release Notes) Does this PR fix a zero-downtime upgrade introduced earlier? * [ ] Yes (Please label this as **<code>backward-incompat</code>**, and complete the section below on Release Notes) Does this PR otherwise need attention when creating release notes? Things to consider: - New configuration options - Deprecation of configurations - Signature changes to public methods/interfaces - New plugins added or old plugins removed * [ ] Yes (Please label this PR as **<code>release-notes</code>** and complete the section on Release Notes) ## Release Notes <!-- If you have tagged this as either backward-incompat or release-notes, you MUST add text here that you would like to see appear in release notes of the next release. --> <!-- If you have a series of commits adding or enabling a feature, then add this section only in final commit that marks the feature completed. Refer to earlier release notes to see examples of text. --> ## Documentation <!-- If you have introduced a new feature or configuration, please add it to the documentation as well. See https://docs.pinot.apache.org/developers/developers-and-contributors/update-document --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
