Jackie-Jiang commented on a change in pull request #7283:
URL: https://github.com/apache/pinot/pull/7283#discussion_r688718642
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/PinotTaskManager.java
##########
@@ -356,7 +357,8 @@ public void registerTaskGenerator(PinotTaskGenerator
taskGenerator) {
* Helper method to schedule tasks (all task types) for the given tables
that have the tasks enabled. Returns a map
* from the task type to the task scheduled.
*/
- private synchronized Map<String, String> scheduleTasks(List<String>
tableNamesWithType, boolean isLeader) {
+ @VisibleForTesting
+ public synchronized Map<String, String> scheduleTasks(List<String>
tableNamesWithType, boolean isLeader) {
Review comment:
Why do we need to expose this API instead of using `scheduleTasks()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
