siddharthteotia edited a comment on pull request #7282: URL: https://github.com/apache/pinot/pull/7282#issuecomment-896472466
Yet to review fully. Before I forget, can you change the name of `_variedLengthDictionaryColumns` to `_varLengthDictionaryColumns` in the output format. It has caused quite a bit of confusion recently (came up today as well) when customers have tried to apply the config and copy the wrong name. https://github.com/apache/pinot/blob/master/pinot-controller/src/main/java/org/apache/pinot/controller/recommender/rules/io/configs/IndexConfig.java#L39 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
