kriti-sc commented on pull request #7081: URL: https://github.com/apache/pinot/pull/7081#issuecomment-892987239
> I would recommend just maintaining some sensitive keys/prefixes within the `TableConfigsRestletResource` and just loop over the map keys and replace the value if the key needs to be obfuscated. You may add a helper method `void obfuscate(Map<String, String> config)`. No need to touch the actual config classes. @Jackie-Jiang Went with changing actual config classes so that obfuscation can be used anywhere and not just in the `tableConfigs` GET API. For example, something mentioned here: https://github.com/apache/pinot/issues/7232 Ideally, the responsibility to specify sensitive config should rest in the integration itself (Kinesis plugin, Kafka plugin, Azure FS plugin, etc), but this would mean a lot of changes and can be picked up incrementally. Please let me know your thoughts. If the reason to change actual config classes does not make sense, will go with the suggested approach. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
