apucher commented on pull request #7081: URL: https://github.com/apache/pinot/pull/7081#issuecomment-892993662
Hi @kriti-sc some high-level thoughts on the approach. Obfuscation is mostly relevant during serialization, i.e. whenever the output sent to the console or via REST api. It may therefore make sense to extract the serialization with obfuscation into an external handler like a `ConfigurationJSONPrinter` (or similar). There, you could serialize the configuration (or any object for that matter) to JSON or nested Map or etc, and then walk this tree structure to obfuscate values of fields that match a certain key name pattern. This has the advantage of being pretty standard, minimizing code modifications, and trivially working across different types of config objects (which are plentiful in pinot) Anyways, just my 2 cents. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
